From: Sebastian Keller <skeller@gnome.org>
Date: Tue, 30 Mar 2021 14:37:05 +0000 (+0200)
Subject: status/network: Disconnect signal handler on destroy in NMConnectionItem
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~616^2^2~82
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=dfc44973de2a5e9d91528519e462638c63fe9dcb;p=gnome-shell.git

status/network: Disconnect signal handler on destroy in NMConnectionItem

Otherwise this can trigger _sync() calls after the objects it is trying
to update have been destroyed.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4013

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1782>
---

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 50423048c..5487fde40 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -128,6 +128,11 @@ var NMConnectionItem = class {
     }
 
     destroy() {
+        if (this._activeConnectionChangedId) {
+            this._activeConnection.disconnect(this._activeConnectionChangedId);
+            this._activeConnectionChangedId = 0;
+        }
+
         this.labelItem.destroy();
         this.radioItem.destroy();
     }